Styleguide
To Start
Styles should be open for extension, but closed for modification. Avoid styles that require overrides elsewhere or are hyper specific to context. For specific naming conventions refer to Naming Classes.
Guiding Principles
- Work in Components & Objects
- Focus on Reuse
- Separate Structure from Skin
- Allow Inheritance
- Aim to be Responsive by Default
Authorship
Variables & Computation
Variables in CSS4 are the same in almost any other language, they store a value. They’re great for arranging the common font families, colors, and spacing you’ll use and want to amend quickly across your project. All global variables should get defined and collected in their own partial. Computation via calc()
should ideally be moved into a variable.
Important
Using the !important
flag on a declaration isn't a great idea. It should always be accompanied by a comment explaining it's need. Utilities are the only reasonable home for an !important
flag.
Declaration Order
- Positioning
- Box model
- Typographic
- Visual
- Misc
References: Code Guide from Mark Otto & Idiomatic.css from Nicolas Gallagher
Mortal Sins
Don’t Style with IDs Selectors
#myElement
. It has performance issues, it supersedes any style declarations from classes on that element and defies the cascading power of CSS. This has been a [best practice] for many years now.Avoid Nesting
.class-name .other-class
While this is legal syntactically, it's unclear and leads to confusion. No declaration should be contingent on another class to look, feel and behave the way it does. Author with that in mind. The only time where this is acceptable is when you are not in control of the markup and are unable to add classes to the HTML, for example if a CMS is spitting out content from a post then it’s acceptable to modify those base elements (p, h3, img, figure, hr) but ideally, the defaults for those elements shouldn’t need much modification from their original declarations.Chaining Selectors
h1.title
Chaining an element to a class to define a selector is limiting and confusing. No good can come from it. It doesn’t make sense to limit a class based on a specific element. It doesn’t make it reusable.Never Overwrite We should aim to extend styling and never overwrite style that's already been written. Overriding a variable/property, is totally fine.
Linting
Obsidian is using Stylelint as its linter. It lints for very specific formatting; here are a few highlights:
- Prefer Single Quotes
- Space After Colon
- No Leading Zeroes
- No IDs
- Single Quotes inside Functions